feat: Better checks in get_connection
#83
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
This PR decreases restriction on
host
,port
,timezone
andtimezone_out
arguments toget_connection
.Approach
From
NEWS.md
:get_connection()
:host
does not need to look like an IP address (e.g. "localhost" is not unrealistic).character
input forport
is allowed if it is a string of digits.timezone
andtimezone_out
is an IANA time zone.Known issues
N/A
Checklist
NEWS.md